jake/elseware
1
0
Fork 0
Code Issues 63 Pull Requests 1 Projects Releases Wiki Activity

sendgc #103

Closed
andy wants to merge 5 commits from sendgc into master
pull from: sendgc
merge into: jake:master
Conversation 1 Commits 5 Files Changed 10 +121 -18
andy commented 2022-04-30 13:08:32 -04:00
Collaborator
Copy Link

you can add friends but you cant actually search for them cus i got fed up from fighting the compiler.

you can add friends but you cant actually search for them cus i got fed up from fighting the compiler.
andy added 4 commits 2022-04-30 13:08:33 -04:00
f is for friends who do stuff together
Some checks failed
continuous-integration/drone/push Build is failing
Details
24fdd705c5
a test i guess
Some checks failed
continuous-integration/drone/push Build is failing
Details
f3294dfce8
andy vs clippy round 8
Some checks failed
continuous-integration/drone/push Build is failing
Details
f2c4094b8f
ci pls work
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
5898a8120a
jake requested changes 2022-04-30 13:33:17 -04:00
Cargo.toml
@ -6,3 +6,3 @@
[dependencies]
libpso = { git = "http://git.sharnoth.com/jake/libpso" }
libpso = { git = "http://git.sharnoth.com/jake/libpso", branch = "sendgc" }
jake commented 2022-04-30 13:26:56 -04:00
Owner
Copy Link

merge this in libpso

merge this in libpso
src/entity/account.rs
@ -12,3 +13,2 @@
#[derive(Copy, Clone, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]
pub struct GuildCardDataId(pub u32);
// TODO: use these
jake commented 2022-04-30 13:27:38 -04:00
Owner
Copy Link

TODO: remove TODO

TODO: remove TODO
src/entity/account.rs Outdated
@ -15,0 +14,4 @@
// TODO: use these
#[derive(Debug)]
pub enum GuildcardError {
GuildcardAlreadyFriend(u32),
jake commented 2022-04-30 13:28:20 -04:00
Owner
Copy Link

should be UserAccountId not u32 (or whatever proper not-number type is expected)

should be `UserAccountId` not `u32` (or whatever proper not-number type is expected)
src/entity/account.rs Outdated
@ -125,19 +131,28 @@ impl NewGuildCardDataEntity {
}
// TODO: implement this properly
jake commented 2022-04-30 13:28:37 -04:00
Owner
Copy Link

TODO: determine if this was implemented properly

TODO: determine if this was implemented properly
src/entity/account.rs Outdated
@ -130,3 +136,2 @@
pub id: GuildCardDataId,
pub user_id: UserAccountId,
pub guildcard: guildcard::GuildCardData,
pub guildcard_data: Box<guildcard::GuildCardData>,
jake commented 2022-04-30 13:31:49 -04:00
Owner
Copy Link

why is this boxed?

why is this boxed?
andy commented 2022-04-30 15:11:09 -04:00
Author
Collaborator
Copy Link

GuildCardData is >50kb cus it contains the friendlist + blocklist.

`GuildCardData` is >50kb cus it contains the friendlist + blocklist.
src/entity/account.rs Outdated
@ -142,1 +146,4 @@
}
pub fn add_friend(&mut self, new_friend: &GuildcardAccept) -> Result<(), GuildcardError> {
let next_open_spot = self.guildcard_data.friends
jake commented 2022-04-30 13:29:55 -04:00
Owner
Copy Link

.iter().position() might be preferable to .enumerate().find()?

`.iter().position()` might be preferable to `.enumerate().find()`?
andy added 1 commit 2022-04-30 15:35:21 -04:00
andy closed this pull request 2023-02-17 16:50:17 -05:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
jake
Labels
Clear labels
item refactor
nice to have
one day maybe someday
release
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
andy chimpyroadkill cmw252 morfin reason jake
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jake/elseware#103
No description provided.
Delete Branch "sendgc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?