shop_sell #47

Closed
andy wants to merge 0 commits from shop_sell into master
Collaborator

nice warez u got there

nice warez u got there
andy added 13 commits 2021-06-21 14:49:18 -04:00
rustfmt weapon.rs
All checks were successful
continuous-integration/drone/push Build is passing
d59e0691d7
add 3 attr weap sell test
All checks were successful
continuous-integration/drone/push Build is passing
9db4c9cc44
handle selling photon tools and untekked weapon test
Some checks failed
continuous-integration/drone/push Build is failing
fbc68c7a26
more selling tests
Some checks failed
continuous-integration/drone/push Build is failing
d84b2fc663
andy vs. clippy round 2
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is passing
1eff61629a
jake requested changes 2021-07-28 16:56:59 -04:00
@ -223,0 +235,4 @@
return Some(10u32)
}
// other item factors?
Some((WeaponShopItem::weapon_from_item(w).price() / 8) as u32)
Owner

this (and other x_from_item) should be impl From<WeaponDetail> for WeaponShopItem. then the code here be w.into().price() / 8 (which might not work due to type inference not inferring enough but should still use standard From trait)

this (and other `x_from_item`) should be `impl From<WeaponDetail> for WeaponShopItem`. then the code here be `w.into().price() / 8` (which might not work due to type inference not inferring enough but should still use standard `From` trait)
@ -847,0 +871,4 @@
sold_item_handle.consume(amount)?;
},
// TODO: put a real error here
Ordering::Greater => {println!("i can't believe you've done this.");},
Owner

ItemMangerError::InvalidSale

`ItemMangerError::InvalidSale`
andy added 2 commits 2021-07-30 22:16:54 -04:00
cleanup todos
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
66d882d336
andy added 1 commit 2021-07-30 22:22:04 -04:00
appease the clip
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
b60463eaa0
andy closed this pull request 2021-08-01 12:38:06 -04:00
jake requested changes 2021-08-02 13:28:06 -04:00
@ -221,2 +222,4 @@
}
}
pub fn get_sell_price(&self) -> Result<u32, ItemManagerError> {
Owner

this made more sense returning an Option I think

this made more sense returning an `Option` I think
Some checks failed
continuous-integration/drone/push Build is failing
Required
Details
continuous-integration/drone/pr Build is failing
Required
Details

Pull request closed

Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jake/elseware#47
No description provided.