andy/floor-limit #29

Merged

jake merged 3 commits from andy/floor-limit into master 2023-02-15 19:59:43 -05:00

Conversation 4 Commits 3 Files Changed 1 +9 -9

andy commented 2023-02-07 20:54:48 -05:00

Collaborator

Copy Link

No description provided.

andy added 2 commits 2023-02-07 20:54:48 -05:00

floor limit packet 58b8fa132c

very important packet data eff9fba20a

andy added 1 commit 2023-02-08 18:36:06 -05:00

rename to match the rest of the code 2dd1161ae7

jake commented 2023-02-15 19:21:39 -05:00

Owner

Copy Link

why is C3 changed here? its being used already and works fine?

why is C3 changed here? its being used already and works fine?

andy commented 2023-02-15 19:44:11 -05:00

Author

Collaborator

Copy Link

why is C3 changed here? its being used already and works fine?

The struct missed the amount being dropped if you dropped a partial stack of an item

> why is C3 changed here? its being used already and works fine? The struct missed the amount being dropped if you dropped a partial stack of an item

jake commented 2023-02-15 19:47:03 -05:00

Owner

Copy Link

thats covered in the followup message 0x29, is that duplicated in both packets?

also if that packet had that extra u32 and we weren't parsing it, it would error out about mismatched pkt length.

thats covered in the followup message 0x29, is that duplicated in both packets? also if that packet had that extra u32 and we weren't parsing it, it would error out about mismatched pkt length.

andy commented 2023-02-15 19:58:09 -05:00

Author

Collaborator

Copy Link

sega duplicated it.

[recv buf] [32, 0, 96, 0, 0, 0, 0, 0, 195, 6, 0, 0, 0, 0, 0, 0, 206, 254, 94, 67, 184, 255, 125, 67, 16, 0, 1, 0, 4, 0, 0, 0]
modify: epoll_fd=4, fd=6, ev=Event { key: 18446744073709551615, readable: true, writable: false }
[recv buf] [20, 0, 96, 0, 0, 0, 0, 0, 41, 3, 0, 0, 16, 0, 1, 0, 4, 0, 0, 0, 0, 0, 0, 0]
[recv buf] [12, 0, 96, 0, 0, 0, 0, 0, 45, 1, 0, 0, 0, 0, 0, 0]
main_loop: sleeping for 75 us
[recv from ClientId(1)] Message(
    Message {
        msg [GameMessage]: DropCoordinates(
            DropCoordinates {
                client [u8]: 0,
                target [u8]: 0,
                map_area [u16]: 0,
                room [u16]: 0,
                x [f32]: 222.99533,
                z [f32]: 253.9989,
                item_id [u32]: 65552,
                amount [u32]: 4,
            },
        ),
    },
)
[recv from ClientId(1)] Message(
    Message {
        msg [GameMessage]: PlayerNoLongerHasItem(
            PlayerNoLongerHasItem {
                client [u8]: 0,
                target [u8]: 0,
                item_id [u32]: 65552,
                amount [u32]: 4,
            },
        ),
    },
)

sega duplicated it. ``` [recv buf] [32, 0, 96, 0, 0, 0, 0, 0, 195, 6, 0, 0, 0, 0, 0, 0, 206, 254, 94, 67, 184, 255, 125, 67, 16, 0, 1, 0, 4, 0, 0, 0] modify: epoll_fd=4, fd=6, ev=Event { key: 18446744073709551615, readable: true, writable: false } [recv buf] [20, 0, 96, 0, 0, 0, 0, 0, 41, 3, 0, 0, 16, 0, 1, 0, 4, 0, 0, 0, 0, 0, 0, 0] [recv buf] [12, 0, 96, 0, 0, 0, 0, 0, 45, 1, 0, 0, 0, 0, 0, 0] main_loop: sleeping for 75 us [recv from ClientId(1)] Message( Message { msg [GameMessage]: DropCoordinates( DropCoordinates { client [u8]: 0, target [u8]: 0, map_area [u16]: 0, room [u16]: 0, x [f32]: 222.99533, z [f32]: 253.9989, item_id [u32]: 65552, amount [u32]: 4, }, ), }, ) [recv from ClientId(1)] Message( Message { msg [GameMessage]: PlayerNoLongerHasItem( PlayerNoLongerHasItem { client [u8]: 0, target [u8]: 0, item_id [u32]: 65552, amount [u32]: 4, }, ), }, ) ```

jake merged commit e1a8ad7fc5 into master 2023-02-15 19:59:43 -05:00

jake referenced this issue from a commit 2023-02-15 19:59:43 -05:00

Merge pull request 'andy/floor-limit' (#29) from andy/floor-limit into master

jake deleted branch andy/floor-limit 2023-02-15 19:59:47 -05:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

andy reason jake

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: jake/libpso#29

No description provided.